Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): Bump github.com/cometbft/cometbft from 0.37.8 to 0.37.9 #2571

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 16, 2024

Bumps github.com/cometbft/cometbft from 0.37.8 to 0.37.9.

Release notes

Sourced from github.com/cometbft/cometbft's releases.

v0.37.9

See the CHANGELOG for this release.

Changelog

Sourced from github.com/cometbft/cometbft's changelog.

v0.37.9

July 16, 2024

This release contains a few minor bug fixes and performance improvements.

BUG FIXES

  • [p2p] Node respects configured max_num_outbound_peers limit when dialing peers provided by a seed node (#486)
  • [blocksync] Do not stay in blocksync if the node's validator voting power is high enough to block the chain while it is not online (#3406)

IMPROVEMENTS

  • [p2p/conn] Remove the usage of a synchronous pool of buffers in secret connection, storing instead the buffer in the connection struct. This reduces the synchronization primitive usage, speeding up the code. (#3403)
Commits
  • f829981 chore: release v0.37.9 (#3516)
  • 9e6d5e5 build(deps): Bump docker/setup-buildx-action from 3.3.0 to 3.4.0 (#3438)
  • 582eb57 build(deps): Bump docker/build-push-action from 6.2.0 to 6.3.0 (#3437)
  • e2666e5 perf(p2p/conn): Remove unneeded global pool buffers in secret connection (bac...
  • 2f4332b fix(blocksync): don't block in blocksync if our voting power is blocking the ...
  • 3f43881 docs: remove not existing key from block search query (backport #3399) (#3410)
  • 25841d8 fix(p2p/pex): respect MaxNumOutboundPeers limit while dialing peers provided ...
  • 411979a docs(rpc): update /abci_info return parameters (backport #3359) (#3393)
  • See full diff in compare view

Most Recent Ignore Conditions Applied to This Pull Request
Dependency Name Ignore Conditions
github.com/cometbft/cometbft [>= 0.38.a, < 0.39]

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Summary by CodeRabbit

  • Dependencies Update
    • Updated the CometBFT library to the latest version for improved functionality and performance.
    • Removed an unnecessary library, streamlining the dependency management of the project.

@dependabot dependabot bot requested a review from a team as a code owner July 16, 2024 02:40
Copy link
Contributor

coderabbitai bot commented Jul 16, 2024

Walkthrough

The project has undergone an update in its dependency management, specifically updating the CometBFT library from version v0.37.8 to v0.37.9. This likely includes bug fixes and performance enhancements. Additionally, the github.com/libp2p/go-buffer-pool dependency has been removed, indicating it is no longer required. These changes streamline the project's dependencies, potentially improving stability and performance.

Changes

Files Change Summary
go.mod Updated github.com/cometbft/cometbft from v0.37.8 to v0.37.9; removed github.com/libp2p/go-buffer-pool v0.1.0.

Poem

🌟 In the meadow where rabbits play,
A library update brightens the day!
CometBFT hops a notch ahead,
While the buffer pool bids farewell, instead.
With bugs vanquished, we leap in glee,
A smoother path for you and me! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Bumps [github.com/cometbft/cometbft](https://github.com/cometbft/cometbft) from 0.37.8 to 0.37.9.
- [Release notes](https://github.com/cometbft/cometbft/releases)
- [Changelog](https://github.com/cometbft/cometbft/blob/v0.37.9/CHANGELOG.md)
- [Commits](cometbft/cometbft@v0.37.8...v0.37.9)

---
updated-dependencies:
- dependency-name: github.com/cometbft/cometbft
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/cometbft/cometbft-0.37.9 branch from 7c5016f to 703666b Compare July 23, 2024 14:34
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.55%. Comparing base (2acc4a7) to head (dbc3bbd).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2571   +/-   ##
=======================================
  Coverage   62.55%   62.55%           
=======================================
  Files         275      275           
  Lines       16035    16035           
=======================================
  Hits        10031    10031           
  Misses       5231     5231           
  Partials      773      773           

@gsk967 gsk967 enabled auto-merge August 12, 2024 12:39
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 2acc4a7 and dbc3bbd.

Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
Files selected for processing (1)
  • go.mod (2 hunks)
Additional comments not posted (2)
go.mod (2)

12-12: Verify compatibility of the cometbft update.

The update from v0.37.8 to v0.37.9 may include important bug fixes and performance improvements. Ensure that the new version is compatible with the existing codebase and that any deprecated or changed functionality is addressed.


12-12: Verify impact of removing go-buffer-pool.

The removal of go-buffer-pool indicates it is no longer needed. Ensure that no functionality relies on this library, or that it has been replaced appropriately.

Verification successful

No impact from the removal of go-buffer-pool.

The removal of the go-buffer-pool dependency does not affect the project, as there are no direct or indirect references to it in the codebase. This suggests that it was not in use.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify that the removal of `go-buffer-pool` does not impact the project.

# Test: Search for any references to `go-buffer-pool` in the codebase.
rg --type go 'go-buffer-pool' -A 5

Length of output: 34


Script:

#!/bin/bash
# Description: Check for any indirect references to `go-buffer-pool` in the codebase by examining import statements and dependencies.

# Test: Search for any import statements or dependencies that might have relied on `go-buffer-pool`.
rg --type go 'import' -A 5 | grep 'go-buffer-pool'

# Test: Check if any other dependencies in `go.mod` might have relied on `go-buffer-pool`.
rg 'require' go.mod -A 5 | grep 'go-buffer-pool'

Length of output: 95

@gsk967 gsk967 added this pull request to the merge queue Aug 12, 2024
Merged via the queue into main with commit 79c800d Aug 12, 2024
21 of 28 checks passed
@gsk967 gsk967 deleted the dependabot/go_modules/github.com/cometbft/cometbft-0.37.9 branch August 12, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant