feat: additional leverage queries #617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toteki
commented
Mar 7, 2022
toteki
commented
Mar 7, 2022
| @@ -23,7 +23,7 @@ func (k Keeper) TokenPrice(ctx sdk.Context, denom string) (sdk.Dec, error) { | |||
|
|
|||
| price, err := k.oracleKeeper.GetExchangeRateBase(ctx, denom) | |||
| if err != nil { | |||
| return sdk.ZeroDec(), err | |||
| return sdk.ZeroDec(), sdkerrors.Wrap(err, "oracle") | |||
There was a problem hiding this comment.
I find myself having to use the rule "denom in error message is capitalized, so the error must be coming from oracle" a lot.
It will be better to prefix this one error return with a label since it's the only place where leverage calls an oracle function.
toteki
commented
Mar 7, 2022
toteki
commented
Mar 7, 2022
|
Just need edit: leaving out |
|
Let's not forget the CLI command handlers too. No need to add a boat load of tests for them, but lets at least have the CLI handlers 👍 |
Codecov Report
@@ Coverage Diff @@
## main #617 +/- ##
==========================================
- Coverage 48.45% 48.08% -0.37%
==========================================
Files 63 64 +1
Lines 7940 8801 +861
==========================================
+ Hits 3847 4232 +385
- Misses 3835 4311 +476
Partials 258 258
|
toteki
requested review from
alexanderbez,
adamewozniak and
facundomedica
as code owners
alexanderbez
reviewed
Mar 7, 2022
alexanderbez
reviewed
Mar 7, 2022
alexanderbez
reviewed
Mar 7, 2022
toteki
commented
Mar 7, 2022
alexanderbez
approved these changes
Mar 7, 2022
mergify bot
pushed a commit
that referenced
this pull request
Mar 7, 2022
(cherry picked from commit c0935d0)
alexanderbez
pushed a commit
that referenced
this pull request
Mar 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change