Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: price-feeder: peggo integration #649

Merged
merged 28 commits into from
Mar 21, 2022
Merged

feat: price-feeder: peggo integration #649

merged 28 commits into from
Mar 21, 2022

Conversation

RafilxTenfen
Copy link
Contributor

Description

  • Modifications to help integrate peggo to use price-feeders
  • Peggo Issue 181
  • Peggo PR

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added appropriate labels to the PR
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@RafilxTenfen RafilxTenfen self-assigned this Mar 15, 2022
@RafilxTenfen RafilxTenfen changed the title Peggo price feeder feat: Peggo price feeder Mar 15, 2022
@RafilxTenfen RafilxTenfen changed the title feat: Peggo price feeder feat: price-feeder: peggo integration Mar 15, 2022
adamewozniak
adamewozniak reviewed Mar 15, 2022
View reviewed changes
price-feeder/oracle/provider/binance.go Outdated Show resolved Hide resolved
price-feeder/oracle/provider/gate.go Outdated Show resolved Hide resolved
price-feeder/oracle/provider/huobi.go Outdated Show resolved Hide resolved
price-feeder/oracle/provider/mock.go Outdated Show resolved Hide resolved
@adamewozniak adamewozniak mentioned this pull request Mar 15, 2022
Merged
18 tasks
@RafilxTenfen RafilxTenfen marked this pull request as ready for review March 16, 2022 22:16
@RafilxTenfen RafilxTenfen requested a review from a team as a code owner March 16, 2022 22:16
@codecov-commenter
Copy link

codecov-commenter commented Mar 17, 2022 •
edited
Loading

Codecov Report

Merging #649 (07bdb9d) into main (ea150c9) will increase coverage by 0.08%.
The diff coverage is 50.34%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #649      +/-   ##
==========================================
+ Coverage   48.05%   48.14%   +0.08%     
==========================================
  Files          64       64              
  Lines        8858     9293     +435     
==========================================
+ Hits         4257     4474     +217     
- Misses       4337     4555     +218     
  Partials      264      264
Impacted Files Coverage Δ
x/leverage/client/cli/query.go 0.00% <0.00%> (ø)
x/leverage/keeper/grpc_query.go 6.31% <0.00%> (-1.03%) ⬇️
x/leverage/types/query.pb.gw.go 0.00% <0.00%> (ø)
ante/fee.go 93.61% <100.00%> (+0.28%) ⬆️
x/leverage/client/tests/suite.go 100.00% <100.00%> (ø)

adamewozniak
adamewozniak reviewed Mar 17, 2022
View reviewed changes
Copy link
Collaborator

@adamewozniak adamewozniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀

price-feeder/oracle/provider/binance.go Outdated Show resolved Hide resolved
price-feeder/oracle/provider/binance.go Outdated Show resolved Hide resolved
price-feeder/oracle/provider/binance.go Outdated Show resolved Hide resolved
price-feeder/oracle/provider/gate.go Outdated Show resolved Hide resolved
price-feeder/oracle/provider/gate.go Outdated Show resolved Hide resolved
price-feeder/oracle/provider/binance.go Outdated Show resolved Hide resolved
price-feeder/oracle/provider/gate.go Outdated Show resolved Hide resolved
price-feeder/oracle/provider/kraken.go Outdated Show resolved Hide resolved
price-feeder/oracle/provider/okx.go Outdated Show resolved Hide resolved
price-feeder/oracle/provider/provider.go Outdated Show resolved Hide resolved
@RafilxTenfen RafilxTenfen requested review from toteki and removed request for alexanderbez March 19, 2022 18:09
adamewozniak
adamewozniak approved these changes Mar 21, 2022
View reviewed changes
Copy link
Collaborator

@adamewozniak adamewozniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm + a few nits :D let's merge this in before #648 so that this pr is unblocked

price-feeder/oracle/oracle.go Outdated Show resolved Hide resolved
price-feeder/oracle/provider/huobi.go Outdated Show resolved Hide resolved
price-feeder/oracle/provider/kraken.go Outdated Show resolved Hide resolved
price-feeder/oracle/provider/mock.go Outdated Show resolved Hide resolved
price-feeder/oracle/provider/osmosis.go Outdated Show resolved Hide resolved
RafilxTenfen and others added 3 commits March 21, 2022 10:05
@RafilxTenfen @adamewozniak
Update comments and struct
f8623d5 
Co-authored-by: Adam Wozniak <29418299+adamewozniak@users.noreply.github.com>
@RafilxTenfen
add changelogs of available pairs
68ce14b
@RafilxTenfen
fix names
028197f
@RafilxTenfen RafilxTenfen requested a review from a team as a code owner March 21, 2022 13:09
@adamewozniak adamewozniak merged commit 58be905 into main Mar 21, 2022
@adamewozniak adamewozniak deleted the peggo-price-feeder branch March 21, 2022 15:00
mergify bot pushed a commit that referenced this pull request Mar 21, 2022
@RafilxTenfen
feat: price-feeder: peggo integration (#649)
5938777 
(cherry picked from commit 58be905)
@mergify mergify bot mentioned this pull request Mar 21, 2022
Merged
adamewozniak pushed a commit that referenced this pull request Mar 21, 2022
@mergify @RafilxTenfen
feat: price-feeder: peggo integration (#649) (#664)
e3cab7b 
(cherry picked from commit 58be905)

Co-authored-by: Rafael Tenfen <rafaeltenfen.rt@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderbez alexanderbez alexanderbez left review comments

@toteki toteki toteki approved these changes

@adamewozniak adamewozniak adamewozniak approved these changes

@facundomedica facundomedica Awaiting requested review from facundomedica

Assignees

@RafilxTenfen RafilxTenfen

Labels
C:Tools C:x/oracle
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@RafilxTenfen @codecov-commenter @alexanderbez @adamewozniak @toteki