Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: x/oracle miss counter cli command #835

Merged
merged 3 commits into from
Apr 26, 2022
Merged

Conversation

adamewozniak
Copy link
Collaborator

Description

Adds a miss counter query to the oracle's cli


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added appropriate labels to the PR
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@adamewozniak adamewozniak marked this pull request as ready for review April 25, 2022 19:23
@adamewozniak adamewozniak requested review from a team as code owners April 25, 2022 19:23
Copy link
Contributor

@RafilxTenfen RafilxTenfen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ^^

@codecov-commenter
Copy link

Codecov Report

Merging #835 (8922e9f) into main (4062f6e) will not change coverage.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #835   +/-   ##
=======================================
  Coverage   50.93%   50.93%           
=======================================
  Files          64       64           
  Lines        9428     9428           
=======================================
  Hits         4802     4802           
  Misses       4383     4383           
  Partials      243      243           
Impacted Files Coverage Δ
x/leverage/types/tx.go 0.00% <0.00%> (ø)
x/leverage/simulation/operations.go 91.66% <100.00%> (ø)

@adamewozniak adamewozniak merged commit 4b9c196 into main Apr 26, 2022
@adamewozniak adamewozniak deleted the woz/miss-counter-query branch April 26, 2022 01:10
mergify bot pushed a commit that referenced this pull request Apr 26, 2022
adamewozniak added a commit that referenced this pull request Apr 26, 2022
(cherry picked from commit 4b9c196)

Co-authored-by: Adam Wozniak <29418299+adamewozniak@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants