Skip to content

Commit

Permalink
refactor(swarm-test): don't implicitly add external addresses
Browse files Browse the repository at this point in the history
This is a safer default than always adding the memory address as external. Kademlia for example depends on whether we have an external address.

Motivated-by: libp2p#4735.

Pull-Request: libp2p#4743.
  • Loading branch information
thomaseizinger authored Oct 30, 2023
1 parent 77a8818 commit c6d87fc
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tests/test_client.rs
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ async fn test_confidence() {
// Randomly test either for public or for private status the confidence.
let test_public = rand::random::<bool>();
if test_public {
client.listen().await;
client.listen().with_memory_addr_external().await;
} else {
let unreachable_addr = "/ip4/127.0.0.1/tcp/42".parse().unwrap();
client.behaviour_mut().probe_address(unreachable_addr);
Expand Down

0 comments on commit c6d87fc

Please sign in to comment.