Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix: watch files change of module_graph in node_modules (#1385)" #1430

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

Jinbao1001
Copy link
Member

@Jinbao1001 Jinbao1001 commented Jul 19, 2024

This reverts commit 3a74d28.

Summary by CodeRabbit

  • 新功能

    • 简化了生成忽略列表的方法,用户现在只需传递一个布尔参数来决定是否包含输出目录。
  • 改进

    • 更新了监视器的逻辑,优化了忽略列表的构建方式,提高了代码的清晰性和可维护性。

Copy link
Contributor

coderabbitai bot commented Jul 19, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

此次修改对 Watcher 结构体及其方法进行了显著调整,主要是移除了 IgnoreListArgs 结构体。现在,get_ignore_list 方法接受单一的布尔参数 with_output_dir,简化了函数签名和代码复杂性。此外,watch 方法也相应更新,直接传递布尔值,而不再使用 IgnoreListArgs 实例,从而增强了代码的清晰性和可维护性。

Changes

文件 更改摘要
crates/mako/src/dev/watch.rs 移除了 IgnoreListArgs 结构体,get_ignore_list 方法现在使用布尔参数 with_output_dir。更新了 watch 方法,简化了对忽略列表的生成逻辑,移除了与 with_node_modules 相关的条件检查。

Poem

在草丛中跳跃的小兔,
代码更新真是美妙,
忽略列表简化了,
维护轻松笑嘻嘻,
让我们一起欢呼吧,
代码清晰如晨曦! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Jinbao1001 Jinbao1001 merged commit 5bc76e9 into master Jul 19, 2024
8 checks passed
@afc163 afc163 deleted the revert/watch_nodeModules branch July 20, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant