fix: watch too many file error #1550
Conversation
Walkthrough此次更改涉及对开发服务器和监视器的实现进行修改，主要包括删除了 Changes
Possibly related PRs
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1550 +/- ##
==========================================
+ Coverage 62.04% 62.08% +0.03%
==========================================
Files 127 127
Lines 15354 15346 -8
==========================================
Hits 9527 9527
+ Misses 5827 5819 -8 ☔ View full report in Codecov by Sentry. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- crates/mako/src/dev.rs (1 hunks)
- crates/mako/src/dev/watch.rs (1 hunks)
- scripts/test-hmr.mjs (1 hunks)
Additional comments not posted (4)
crates/mako/src/dev/watch.rs (2)
Line range hint
21-23: 代码更改已批准代码更改已批准。
Line range hint
1-1: 验证删除refresh_watch方法的影响请确保删除
refresh_watch方法不会引入任何问题，并验证所有调用该方法的地方是否已被正确处理。运行以下脚本以验证代码库中是否存在对
refresh_watch方法的调用：Verification successful
确认
refresh_watch方法的删除不会引入问题经过验证，
refresh_watch方法的删除是完整且有意的。代码库中没有遗留的引用或定义，因此不会影响现有功能。Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # 描述：验证代码库中是否存在对 `refresh_watch` 方法的调用。 # 测试：搜索 `refresh_watch` 方法的调用。期望：没有调用。 rg --type rust -A 5 $'refresh_watch'Length of output: 35
Script:
#!/bin/bash # 描述：搜索 `refresh_watch` 方法的定义和引用。 # 搜索：查找 `refresh_watch` 方法的定义。 rg --type rust -A 5 'fn refresh_watch' # 搜索：查找任何提到 `refresh_watch` 的注释或引用。 rg --type rust -A 5 'refresh_watch'Length of output: 76
Script:
#!/bin/bash # 描述：检查 git 历史中是否有 `refresh_watch` 的任何提及。 # 搜索：在 git 历史中查找 `refresh_watch` 的提及。 git log -p -S 'refresh_watch'Length of output: 9667
crates/mako/src/dev.rs (1)
Line range hint
1-1: 验证删除watcher.refresh_watch()?;的影响请确保删除
watcher.refresh_watch()?;不会引入任何问题，并验证所有调用该方法的地方是否已被正确处理。运行以下脚本以验证代码库中是否存在对
refresh_watch方法的调用：Verification successful
删除
watcher.refresh_watch()?;不会引入问题在代码库中没有找到
refresh_watch方法的定义或调用，这表明删除该行不会对代码库产生影响。请确保在未来的开发中保持这种一致性。Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # 描述：验证代码库中是否存在对 `refresh_watch` 方法的调用。 # 测试：搜索 `refresh_watch` 方法的调用。期望：没有调用。 rg --type rust -A 5 $'refresh_watch'Length of output: 35
Script:
#!/bin/bash # Search for the definition of the `refresh_watch` method in the codebase. rg --type rust 'fn refresh_watch' # Search for any usage of `refresh_watch` in the codebase. rg --type rust 'refresh_watch'Length of output: 66
scripts/test-hmr.mjs (1)
1561-1648: 测试用例已批准新的测试用例已批准。
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- crates/mako/src/dev.rs (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- crates/mako/src/dev.rs
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (7)
- packages/bundler-mako/package.json (1 hunks)
- packages/mako/npm/darwin-arm64/package.json (1 hunks)
- packages/mako/npm/darwin-x64/package.json (1 hunks)
- packages/mako/npm/linux-arm64-musl/package.json (1 hunks)
- packages/mako/npm/linux-x64-gnu/package.json (1 hunks)
- packages/mako/npm/linux-x64-musl/package.json (1 hunks)
- packages/mako/package.json (2 hunks)
Files skipped from review due to trivial changes (4)
- packages/mako/npm/darwin-arm64/package.json
- packages/mako/npm/darwin-x64/package.json
- packages/mako/npm/linux-arm64-musl/package.json
- packages/mako/npm/linux-x64-gnu/package.json
Additional comments not posted (3)
packages/mako/npm/linux-x64-musl/package.json (1)
3-3: 版本更新审查此次版本从
0.8.7更新至0.8.8-rc.1，表明这是一个候选发布版本。建议检查此版本更新是否引入了任何可能影响包稳定性的重大变更或依赖项。packages/bundler-mako/package.json (1)
6-6: 依赖版本更新审查
@umijs/mako的版本从0.8.7更新至0.8.8-rc.1。建议进行彻底测试，以确保新版本的依赖项与现有功能的兼容性和集成性。packages/mako/package.json (1)
77-81: 可选依赖版本更新审查多个可选依赖项的版本已从
0.8.7更新至0.8.8-rc.1。建议在不同的平台和配置上进行全面测试，以确保所有更新的依赖项的兼容性和稳定性。
In an antd docs scenario, modifying a MD file triggered the refresh function at least 40 times. Parallel builds quickly led to an excessive number of file handles. Here, the refresh logic was removed, and the existing test cases for that scenario were verified to still pass. Additionally, extra test cases were added to cover previously untested scenarios.
Summary by CodeRabbit
Summary by CodeRabbit
新功能
0.8.11，可能包含新特性和改进。修复