fix: bad output when chunk_loading_global containing quotation mark

[xusd320]

If chunk_loading_global contains single quote, the output will be broken.

((typeof globalThis !== 'undefined' ? globalThis : self)['makoChunk_application's name'] 

Summary by CodeRabbit

• 新功能
  • 改进了对 chunk_loading_global 属性的处理，增强了生成的 JavaScript 代码的安全性和可读性。

[coderabbitai]

Walkthrough

此次更改主要集中在 str_impl.rs 文件中的 render_normal_js_chunk 函数，增强了对上下文配置中 chunk_loading_global 属性的处理。通过使用 serde_json::to_string 将 chunk_loading_global 字符串转换为 JSON 安全格式，并将其分配给新变量 safe_prop，从而确保安全处理，避免生成的 JavaScript 代码中包含单引号或双引号的问题。同时，chunk_prefix_code 字符串的格式化也进行了调整，使用 safe_prop 代替直接引用 context.config.output.chunk_loading_global。

Changes

文件路径	更改摘要
crates/mako/src/generate/chunk_pot/str_impl.rs	修改 render_normal_js_chunk 函数以安全处理 chunk_loading_global 属性，转换为 JSON 安全格式并改进字符串格式化。

Possibly related PRs

• fix: chunk file name should be url-friendly #1434: 此 PR 修改了 Chunk 实现中的字符串表示，可能与主 PR 中的块属性处理相关。
• refactor: avoid underscore prefix for chunk file name #1471: 类似于 fix: chunk file name should be url-friendly #1434，此 PR 也处理了 Chunk 实现中的字符串表示，可能与主 PR 的块属性处理变化相关。
• fix: 🐛 js.map file use js file's path in stat.json #1506: 此 PR 增强了源映射文件路径的处理，与主 PR 关注的块加载属性处理相关。
• refactory: in str-impl chunk generate, remove cm when merge_code_and_sourcemap #1541: 此 PR 修改了 merge_code_and_sourcemap 函数，直接与源映射和块生成的处理相关，紧密与主 PR 的变化对齐。

Poem

在月光下，兔子跳跃，
代码变更，真是妙趣横生。
安全处理，避免错误，
让我们的 JavaScript 更加清晰。
小小改动，带来新生，
兔子欢呼，代码更胜！ 🐇✨

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 23ed602 and d0ab74a.

Files selected for processing (1)

• crates/mako/src/generate/chunk_pot/str_impl.rs (1 hunks)

Files skipped from review as they are similar to previous changes (1)

• crates/mako/src/generate/chunk_pot/str_impl.rs

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 62.04%. Comparing base (4897e32) to head (d0ab74a).
Report is 2 commits behind head on master.

Files with missing lines	Patch %	Lines
crates/mako/src/generate/chunk_pot/str_impl.rs	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1582      +/-   ##
==========================================
+ Coverage   62.03%   62.04%   +0.01%     
==========================================
  Files         127      127              
  Lines       15353    15354       +1     
==========================================
+ Hits         9524     9527       +3     
+ Misses       5829     5827       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.