Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: 🔥 remove unnecessary transform #1727

Merged
merged 1 commit into from
Dec 18, 2024
Merged

refactor: 🔥 remove unnecessary transform #1727

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions crates/mako/src/build/transform.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ use crate::visitors::css_px2rem::Px2Rem;
use crate::visitors::default_export_namer::DefaultExportNamer;
use crate::visitors::dynamic_import_to_require::DynamicImportToRequire;
use crate::visitors::env_replacer::{build_env_map, EnvReplacer};
use crate::visitors::fix_helper_inject_position::FixHelperInjectPosition;
use crate::visitors::fix_symbol_conflict::FixSymbolConflict;
use crate::visitors::import_meta_env_replacer::ImportMetaEnvReplacer;
use crate::visitors::import_template_to_string_literal::ImportTemplateToStringLiteral;
Expand Down Expand Up @@ -101,10 +100,6 @@ impl Transform {
top_level_mark,
is_ts || is_tsx,
)),
// fix helper inject position
// should be removed after upgrade to latest swc
// ref: https://github.com/umijs/mako/issues/1193
Box::new(FixHelperInjectPosition::new()),
Box::new(FixSymbolConflict::new(top_level_mark)),
Box::new(NewUrlAssets {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The removal of FixHelperInjectPosition seems appropriate as it was marked for removal after upgrading to the latest SWC. Ensure that all dependencies on this transform are indeed obsolete.

context: context.clone(),
Expand Down
1 change: 0 additions & 1 deletion crates/mako/src/visitors.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ pub(crate) mod dep_replacer;
pub(crate) mod dynamic_import;
pub(crate) mod dynamic_import_to_require;
pub(crate) mod env_replacer;
pub(crate) mod fix_helper_inject_position;
pub(crate) mod fix_symbol_conflict;
pub(crate) mod import_meta_env_replacer;
pub(crate) mod import_template_to_string_literal;
Expand Down
200 changes: 0 additions & 200 deletions crates/mako/src/visitors/fix_helper_inject_position.rs
View file
Open in desktop

This file was deleted.

Loading