Skip to content

Commit

Permalink
chore: Merge branch 'next' of into feat/create-qiankun
Browse files Browse the repository at this point in the history
  • Loading branch information
qiYuei committed Dec 28, 2023
2 parents a2e539b + ad64bec commit 30304fc
Show file tree
Hide file tree
Showing 7 changed files with 25 additions and 23 deletions.
5 changes: 5 additions & 0 deletions .changeset/clean-walls-hang.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@qiankunjs/webpack-plugin": patch
---

fix: move cheerio to dependencies
1 change: 1 addition & 0 deletions .changeset/pre.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
},
"changesets": [
"big-cougars-draw",
"clean-walls-hang",
"clever-carpets-vanish",
"clever-dragons-ring",
"empty-lions-rescue",
Expand Down
4 changes: 2 additions & 2 deletions packages/sandbox/src/core/membrane/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -148,8 +148,8 @@ export class Membrane {
const actualTarget = propertiesWithGetter.has(p)
? incubatorContext
: p in membraneTarget
? membraneTarget
: incubatorContext;
? membraneTarget
: incubatorContext;
const value = actualTarget[p as never];

// frozen value should return directly, see https://github.com/umijs/qiankun/issues/2015
Expand Down
2 changes: 1 addition & 1 deletion packages/shared/src/fetch-utils/wrapFetchWithCache.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export const wrapFetchWithCache: (fetch: Fetch) => Fetch = (fetch) => {
const lruCache = getGlobalCache();

const cachedFetch: Fetch = (input, init) => {
const fetchInput = input as Parameters<Fetch>[0];
const fetchInput = input;
const cacheKey = getCacheKey(fetchInput);
const wrapFetchPromise = async (promise: Promise<Response>): Promise<Response> => {
try {
Expand Down
6 changes: 6 additions & 0 deletions packages/webpack-plugin/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# @qiankunjs/webpack-plugin

## 0.0.1-rc.4

### Patch Changes

- 35f7863: fix: move cheerio to dependencies

## 0.0.1-rc.3

### Patch Changes
Expand Down
6 changes: 3 additions & 3 deletions packages/webpack-plugin/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@qiankunjs/webpack-plugin",
"version": "0.0.1-rc.3",
"version": "0.0.1-rc.4",
"description": "",
"main": "./dist/cjs/index.js",
"module": "./dist/esm/index.js",
Expand All @@ -20,11 +20,11 @@
"author": "Hermanna",
"license": "MIT",
"dependencies": {
"webpack-sources": "^3.2.3"
"webpack-sources": "^3.2.3",
"cheerio": "1.0.0-rc.12"
},
"devDependencies": {
"@types/webpack-sources": "^3.2.1",
"cheerio": "1.0.0-rc.12",
"webpack": "^4.0.0 || ^5.0.0"
}
}
24 changes: 7 additions & 17 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 30304fc

Please sign in to comment.