Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: sanbox proxy's bound function bind this at runtime #1518

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: sanbox proxy's bound function bind this at runtime #1518

wants to merge 3 commits into from

Conversation

godky
Copy link

@godky godky commented Jun 17, 2021

Checklist
  • npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

@godky godky changed the title fix: sanbox proxy's bounded function lose reference of this fix: sanbox proxy's bound function bind this at runtime Jun 18, 2021
kuitos
kuitos requested changes Jun 21, 2021
View reviewed changes
src/sandbox/common.ts Show resolved Hide resolved
@kuitos kuitos mentioned this pull request Jun 22, 2021
Merged
2 tasks
@kuitos
Copy link
Member

kuitos commented Jun 22, 2021

合一下主分支，合并之后 ci 能过应该就没啥大问题

@godky
Merge from umijs/master
fc36bbd 
Merge from umijs/master
godky
godky commented Jun 23, 2021
View reviewed changes
Copy link
Author

@godky godky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuitos kuitos kuitos requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sandbox proxy result in function lose apply this
2 participants
@godky @kuitos