feat: remove webpack chunk cache attributes just while there are multi instances loaded on document #2873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…i instances loaded on document
🦋 Changeset detectedLatest commit: 474a6b0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
bravepg
reviewed
Jan 4, 2024
| @@ -71,13 +80,16 @@ export default async function loadApp<T extends ObjectType>( | |||
| unmountSandbox = () => sandboxContainer.unmount(); | |||
| } | |||
|
|
|||
| if (instanceId > 1) { | |||
| removeWebpackChunkCacheWhenAppHaveMultiInstance(appName); | |||
There was a problem hiding this comment.
为什么改成第二次 load 的时候才移除 data-webpack 的标识呀？以前的形式有什么问题吗？
There was a problem hiding this comment.
data-webpack 本身是有用的，可以做一些 chunk 提前加载的优化，不能无脑删掉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
当且仅当文档上同时挂载
同一个应用多次时，需要移除 webpack 的缓存，从而避免后续挂载的子应用实例因为命中了 webpack 的缓存，从而不再新建对应的 chunk script，导致 chunk 缺失