Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(qiankun): should remove internal cache of loadMicroApp while loading failed #2922

Merged
merged 2 commits into from
Mar 6, 2024
Merged

fix(qiankun): should remove internal cache of loadMicroApp while loading failed #2922

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2bcea51
fix(qiankun): should remove internal cache of loadMicroApp while load…
kuitos Mar 5, 2024
5aeded6
Create poor-squids-hide.md
kuitos Mar 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/poor-squids-hide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"qiankun": patch
---

fix(qiankun): should remove internal cache of loadMicroApp while loading failed
11 changes: 10 additions & 1 deletion packages/qiankun/src/apis/loadMicroApp.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,12 +71,21 @@ export function loadMicroApp<T extends ObjectType>(

const parcelConfigObjectGetterPromise = loadApp(app, userConfiguration, lifeCycles);

let parcelConfigObjectGetter: ParcelConfigObjectGetter | undefined;

if (containerXPath) {
const appContainerXPathKey = getContainerXPathKey(containerXPath);
appConfigPromiseGetterMap.set(appContainerXPathKey, parcelConfigObjectGetterPromise);
try {
parcelConfigObjectGetter = await parcelConfigObjectGetterPromise;
} catch (e) {
appConfigPromiseGetterMap.delete(appContainerXPathKey);
throw e;
}
}

return (await parcelConfigObjectGetterPromise)(container);
parcelConfigObjectGetter = parcelConfigObjectGetter || (await parcelConfigObjectGetterPromise);
return parcelConfigObjectGetter(container);
};

if (!started) {
Expand Down
Loading