fix(ssr): render not work in dev (#6165)

* fix(ssr): render not work in dev * chore: comment * fix: ssr * chore: writeToDisk
umijs · Feb 23, 2021 · bede27c · bede27c
1 parent c57e10f
commit bede27c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/packages/bundler-webpack/src/index.ts b/packages/bundler-webpack/src/index.ts
@@ -79,13 +79,15 @@ class Bundler {
     bundleImplementor?: typeof defaultWebpack;
   }): IServerOpts {
     const compiler = bundleImplementor(bundleConfigs);
-    const { devServer } = this.config;
+    const { ssr, devServer } = this.config;
     // 这里不做 winPath 处理，是为了和下方的 path.sep 匹配上
     // @ts-ignore
     const compilerMiddleware = webpackDevMiddleware(compiler, {
       // must be /, otherwise it will exec next()
       publicPath: '/',
       logLevel: 'silent',
+      // if `ssr` set false, next() into server-side render
+      ...(ssr ? { index: false } : {}),
       writeToDisk: devServer && devServer?.writeToDisk,
       watchOptions: {
         // not watch outputPath dir and node_modules

diff --git a/packages/preset-built-in/src/plugins/commands/build/applyHtmlWebpackPlugin.ts b/packages/preset-built-in/src/plugins/commands/build/applyHtmlWebpackPlugin.ts
@@ -64,7 +64,7 @@ export default function (api: IApi) {
 
   api.modifyBundleConfig((bundleConfig, { env, type, bundler: { id } }) => {
     const enableWriteToDisk =
-      api.config.devServer && api.config.devServer?.writeToDisk;
+      api.config.devServer && api.config.devServer.writeToDisk;
     if (
       (env === 'production' || enableWriteToDisk) &&
       id === 'webpack' &&