Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ssr): render not work in dev #6165

Merged
merged 4 commits into from
Feb 23, 2021
Merged

fix(ssr): render not work in dev #6165

merged 4 commits into from
Feb 23, 2021

Conversation

ycjcl868
Copy link
Contributor

@ycjcl868 ycjcl868 commented Feb 23, 2021 •
edited
Loading

Checklist
  • npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

@sorrycc
Copy link
Member

sorrycc commented Feb 23, 2021

master 和 3.3.x 都要提，没明白为啥改 userConfig 能解这个问题？

@sorrycc
Copy link
Member

sorrycc commented Feb 23, 2021

加个注释描述下，不然后面看就搞不懂为啥用 userConfig 了。

@codecov
Copy link

codecov bot commented Feb 23, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (3.3.x@c57e10f). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             3.3.x    #6165   +/-   ##
========================================
  Coverage         ?   82.80%           
========================================
  Files            ?      159           
  Lines            ?     3535           
  Branches         ?      956           
========================================
  Hits             ?     2927           
  Misses           ?      598           
  Partials         ?       10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c57e10f...ffbd2e7. Read the comment docs.

@ycjcl868
Copy link
Contributor Author

master 和 3.3.x 都要提，没明白为啥改 userConfig 能解这个问题？

master 合 3.3.x

@ycjcl868
Copy link
Contributor Author

加个注释描述下，不然后面看就搞不懂为啥用 userConfig 了。

done

@sorrycc sorrycc merged commit bede27c into 3.3.x Feb 23, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix-ssr-dev-render-not-work branch February 23, 2021 09:43
sorrycc pushed a commit that referenced this pull request Feb 26, 2021
@ycjcl868
chore: 3.3.x to master (#6169)
c284053 
* fix(ssr): render not work in dev (#6165)

* fix(ssr): render not work in dev

* chore: comment

* fix: ssr

* chore: writeToDisk

* chore release script (#6167)

* chore: release script

* chore: script

* chore: otp

* release: v3.3.9

* chore: dep

* chore: config

* chore: release support otp

* chore: enable-otp

* chore: otp
This was referenced Mar 16, 2021
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ycjcl868 @sorrycc