Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove --max_old_space_size from ci #6011

Merged
merged 2 commits into from
Jan 17, 2021
Merged

chore: remove --max_old_space_size from ci #6011

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
122f16f
chore: remove --max_old_space_size from ci
sorrycc Jan 17, 2021
945299c
fix: ts lint
sorrycc Jan 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,5 +41,3 @@ jobs:
HEADLESS: false
PROGRESS: none
NODE_ENV: test
NODE_OPTIONS: --max_old_space_size=4096

5 changes: 4 additions & 1 deletion packages/preset-built-in/src/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,14 +292,15 @@ test('ssr using stream', (done) => {
path: '/',
mode: 'stream',
mountElementId: 'root',
// @ts-ignore
}).then(({ html, rootContainer }) => {
expect(rootContainer instanceof Stream).toBeTruthy();
expect(html instanceof Stream).toBeTruthy();
const expectBytes = Buffer.from(
'<div><ul><li>hello</li><li>world</li></ul></div>',
);
let bytes = Buffer.from('');
rootContainer.on('data', (chunk) => {
rootContainer.on('data', (chunk: any) => {
bytes = Buffer.concat([bytes, chunk]);
});
rootContainer.on('end', () => {
Expand All @@ -311,6 +312,7 @@ test('ssr using stream', (done) => {
});

test('ssr htmlTemplate', async () => {
// @ts-ignore
process.env.__IS_SERVER = true;
const cwd = join(fixtures, 'ssr-htmlTemplate');
const tmpServerFile = join(cwd, '.umi-test', 'core', 'server.ts');
Expand Down Expand Up @@ -369,6 +371,7 @@ test('ssr htmlTemplate', async () => {
});

xtest('ssr dynamicImport', async () => {
// @ts-ignore
process.env.__IS_SERVER = true;
const cwd = join(fixtures, 'ssr-dynamicImport');
const corePath = join(cwd, '.umi-test', 'core');
Expand Down