Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix types on error message extraction #1689

Merged
merged 1 commit into from
Oct 28, 2023
Merged

fix types on error message extraction #1689

merged 1 commit into from
Oct 28, 2023

Conversation

akellbl4
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Oct 28, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (eba4473) 61.55% compared to head (2672c07) 61.55%.
Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #1689    +/-   ##
========================================
  Coverage   61.55%   61.55%            
========================================
  Files         133      133            
  Lines        3004     3004            
  Branches      759      717    -42     
========================================
  Hits         1849     1849            
- Misses       1038     1151   +113     
+ Partials      117        4   -113     
Files Coverage Δ
frontend/apps/remark42/app/common/types.ts 100.00% <ø> (ø)
.../remark42/app/components/comment/comment-votes.tsx 95.55% <ø> (ø)
frontend/apps/remark42/app/utils/errorUtils.ts 84.61% <100.00%> (ø)
...ribe-by-email/comment-form__subscribe-by-email.tsx 90.40% <0.00%> (ø)
...y-telegram/comment-form__subscribe-by-telegram.tsx 93.50% <0.00%> (ø)
...ark42/app/components/comment-form/comment-form.tsx 53.30% <25.00%> (ø)

... and 23 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

size-limit report 📦

Path Size
public/embed.mjs 2.03 KB (0%)
public/remark.mjs 73.1 KB (+0.01% 🔺)
public/remark.css 8.24 KB (0%)
public/last-comments.mjs 35.63 KB (-0.01% 🔽)
public/last-comments.css 3.73 KB (0%)
public/deleteme.mjs 12.06 KB (0%)
public/counter.mjs 749 B (0%)

@umputun umputun merged commit 62aaa35 into master Oct 28, 2023
8 of 10 checks passed
@paskal paskal added this to the v1.13.0 milestone Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants