Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add RTL support #1799

Merged
merged 2 commits into from
Aug 24, 2024
Merged

add RTL support #1799

merged 2 commits into from
Aug 24, 2024

Conversation

adueck
Copy link
Contributor

@adueck adueck commented Jul 26, 2024

This pull request adds support for RTL (right-to-left) languages. By adding dir=auto to the relevant inputs, divs and textareas you get automatic support of RTL languages, with no detriment or loss in functionality to LTR languages.

See this excellent summary PSA: Add dir="auto" to your inputs and textareas.

Before:

Screenshot 2024-07-25 at 10 12 16 PM

After:

Screenshot 2024-07-25 at 10 01 30 PM

@adueck adueck requested a review from umputun as a code owner July 26, 2024 02:13
@adueck adueck changed the title added RTL support add RTL support Jul 29, 2024
@adueck
Copy link
Contributor Author

adueck commented Jul 30, 2024

Thanks for approving this! Looks like there's just an issue with the dependencies for the tests to run?

failed to solve: mcr.microsoft.com/playwright:v1.44-jammy: failed to resolve source metadata for mcr.microsoft.com/playwright:v1.44-jammy: mcr.microsoft.com/playwright:v1.44-jammy: not found

@paskal
Copy link
Collaborator

paskal commented Jul 30, 2024

Playwright will be fixed in #1802.

@paskal
Copy link
Collaborator

paskal commented Aug 4, 2024

@akellbl4 can you please look into pnpm problem? It's not related to the changes in the PR.

@adueck
Copy link
Contributor Author

adueck commented Aug 6, 2024

Hmm, sorry did I do something wrong when I did pnpm install in my fork? If you want I could do another fork/pull request without touching pnpm and see if all the checks pass smoothly.

@paskal
Copy link
Collaborator

paskal commented Aug 6, 2024

You did nothing wrong, I think master branch is broken at the moment.

@paskal
Copy link
Collaborator

paskal commented Aug 24, 2024

@umputun let's merge this one, seems like checks are broken in master: we will deal with them later.

@umputun umputun merged commit 0bc85a6 into umputun:master Aug 24, 2024
2 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants