Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CSP img-src directive to allow everything without proxy #1825

Merged
merged 1 commit into from
Oct 20, 2024

Conversation

paskal
Copy link
Collaborator

@paskal paskal commented Oct 20, 2024

Change the default img-src value to "*" and sets it to "'self'" when image proxy is enabled. The previous state was inversion of this logic which was wrong.

Copy link

Pull Request Test Coverage Report for Build 11429498254

Details

  • 1 of 2 (50.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.898%

Changes Missing Coverage Covered Lines Changed/Added Lines %
backend/app/rest/api/rest.go 1 2 50.0%
Totals Coverage Status
Change from base Build 11355610412: 0.0%
Covered Lines: 5987
Relevant Lines: 7052

💛 - Coveralls

Change the default img-src value to "*" and sets it to "'self'" when
image proxy is enabled. The previous state was inversion of this logic
which was wrong.
@paskal paskal marked this pull request as ready for review October 20, 2024 20:53
@paskal paskal requested a review from umputun as a code owner October 20, 2024 20:53
@umputun umputun merged commit 6140d82 into master Oct 20, 2024
3 checks passed
@umputun umputun deleted the paskal/fix_img_src_CSP branch October 20, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants