-
-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consul catalog provider #56
Conversation
As it marked as a draft and review wasn't requested I haven't reviewed it for real, just took a quick look. I glad to see you have not used some SDK/library for this and kept it all with stdlib, I like it a lot. The code looks clean and readable. I notice just a few minor things, like TrimRight instead of TrimSuffix you probably meant. thx |
I use TrimRight for 'path//' cases |
Oops, I have to add documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not analyzed what this code is doing but rather how it's doing things. I think it can be simplified and be much easier to digest
see also https://github.com/umputun/reproxy/pull/56/checks?check_run_id=2426021843 running the same linter locally is a good way to catch all of them before it hits CI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't want to repeat all remarks I made before, but many of them not even touched
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Will be nice if you can fix the linter warn
one more thing - pls rebase it to a single commit or a few logically isolated commits. |
Implement consul catalog provider
Issue #10