Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config file support #10

Merged
merged 4 commits into from
Jan 28, 2023
Merged

Config file support #10

merged 4 commits into from
Jan 28, 2023

Conversation

umputun
Copy link
Owner

@umputun umputun commented Jan 28, 2023

resolves #9

@umputun
bump to go 1.19, update deps
2603f35
@umputun
support config file, optional
621f539 
the file parsed back to the same format expected by cli. Both CLI and config can be present, CLI has priority.
@umputun
lint: naming warnings
cf6d976
@umputun
add docs to readme
f11785c
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4030402742

  • 88 of 96 (91.67%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.0%) to 82.927%
Changes Missing Coverage Covered Lines Changed/Added Lines %
app/config/config.go 59 61 96.72%
app/main.go 29 35 82.86%
Totals Coverage Status
Change from base Build 2899647897: 1.0%
Covered Lines: 646
Relevant Lines: 779
💛 - Coveralls

@umputun umputun merged commit 8e97679 into master Jan 28, 2023
@umputun umputun deleted the config branch January 28, 2023 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support of configuration file
2 participants
@umputun @coveralls