Fix configuration for Nginx service (status_url prefix) #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe this issue should be addressed differently. Having nginx:// prefix/protocol for the URL is necessary for the command line setup but looks unnatural in the configuration file. So, I suggest keeping the normal-looking URL but handling it in a similar way as it has done for RMQ config |
|
Thanks! |
|
Thank you for taking care of this bug. All this configuration file thing is not something that I actively use, and some subtle bugs are possible. If you encounter anything similar or need further clarification on this, just let me know. Feel free to report any issues you run into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this fix for Nginx in config file only status_ulr without "nginx" prefix works.