Update docker_provider.go #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump docker api version from 1.22 to 1.24
Fix tests
Pull Request Test Coverage Report for Build 7743428515
💛 - Coveralls |
|
Thank you for the PR Will this change break compatibility with older dockers? If so, we probably need something that will try/pick an appropriate version of the protocol. upd: I checked several servers with really old dockers and found one with 17.06.2 which is still fine after the change, as it requeries 1.30 (minimum version 1.12) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump docker api version from 1.22 to 1.24
see #15