Don't make expectations on the downloads folder #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All of these system tests are a nightmare. But, at some point these ones made the transition from frequently failing to always failing. I believe it has something to de with a change Chrome made to its headless mode. And of course, these aren't even "downloads" in real life. They're `Content-Disposition: inline`. So it's only the tests that ever saw them as "downloads".
|
Now, did the tests... pass? Of course not. |
werebus
force-pushed
the
werebus/stop-download-assertions
branch
from
639c04f
to
95db5e8
Compare
benmelz
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of these system tests are a nightmare. But, at some point these two specs made the transition from frequently failing to always failing. I believe it has something to de with a change Chrome made to its headless mode.
And of course, these aren't even "downloads" in real life. They're
Content-Disposition: inline. So it's only the tests that ever saw them as "downloads".