Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: report correct ruleId from original linter #22

Merged
merged 2 commits into from
Jun 25, 2021
Merged

Conversation

JounQin
Copy link
Member

@JounQin JounQin commented Jun 25, 2021

No description provided.

@JounQin JounQin added the enhancement New feature or request label Jun 25, 2021
@JounQin JounQin self-assigned this Jun 25, 2021
@changeset-bot
Copy link

changeset-bot bot commented Jun 25, 2021

🦋 Changeset detected

Latest commit: 4787259

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
eslint-plugin-htm Minor
eslint-plugin-markup Minor
eslint-plugin-utils Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 25, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@codecov
Copy link

codecov bot commented Jun 25, 2021

Codecov Report

Merging #22 (448a22c) into main (1fcd7fa) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 448a22c differs from pull request most recent head 4787259. Consider uploading reports for the commit 4787259 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##              main       #22   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        15    +5     
  Lines           80       110   +30     
  Branches        10        12    +2     
=========================================
+ Hits            80       110   +30     
Impacted Files Coverage Δ
packages/htm/src/configs.ts 100.00% <100.00%> (ø)
packages/htm/src/index.ts 100.00% <100.00%> (ø)
packages/htm/src/rules/html.ts 100.00% <100.00%> (ø)
packages/markup/src/configs.ts 100.00% <100.00%> (ø)
packages/markup/src/index.ts 100.00% <100.00%> (ø)
packages/markup/src/rules/markup.ts 100.00% <100.00%> (ø)
packages/utils/src/helpers.ts 100.00% <100.00%> (ø)
packages/utils/src/index.ts 100.00% <100.00%> (ø)
packages/utils/src/processors.ts 100.00% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fcd7fa...4787259. Read the comment docs.

@JounQin JounQin merged commit 2270c8b into main Jun 25, 2021
@JounQin JounQin deleted the feat/json-message branch June 25, 2021 16:10
@pr-triage pr-triage bot added the PR: merged label Jun 25, 2021
@github-actions github-actions bot mentioned this pull request Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request PR: merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant