Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade to sql-formatter v15, add dataTypeCase and keywordCase options #328

Merged
merged 3 commits into from
Dec 9, 2023
Merged

feat: upgrade to sql-formatter v15, add dataTypeCase and keywordCase options #328

merged 3 commits into from
Dec 9, 2023

Conversation

karlhorky
Copy link
Contributor

Closes #326

Copy link

changeset-bot bot commented Dec 9, 2023

🦋 Changeset detected

Latest commit: c7845e5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
prettier-plugin-sql Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codesandbox-ci bot commented Dec 9, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@JounQin
Copy link
Member

JounQin commented Dec 9, 2023

@karlhorky Please fix the CI issue about formatting.

Copy link

codecov bot commented Dec 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1272f18) 87.73% compared to head (c7845e5) 87.73%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #328   +/-   ##
=======================================
  Coverage   87.73%   87.73%           
=======================================
  Files          10       10           
  Lines         163      163           
  Branches       43       43           
=======================================
  Hits          143      143           
  Misses         19       19           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@karlhorky
Copy link
Contributor Author

@JounQin I think that this is ready to go.

Before the release, maybe prettier-plugin-sql@0.18.0 should also include the dialect option?

@JounQin JounQin merged commit ea85a65 into un-ts:master Dec 9, 2023
17 checks passed
@karlhorky karlhorky deleted the upgrade-to-sql-formatter-15 branch December 9, 2023 18:28
@JounQin JounQin mentioned this pull request Dec 9, 2023
@JounQin
Copy link
Member

JounQin commented Dec 10, 2023

@karlhorky If you have time to work on that new feature, I'll wait for it before releasing.

@karlhorky
Copy link
Contributor Author

@JounQin ah, I mentioned in #322 that it would be great if you could take over the dialect option, not sure when I'll get to it

@JounQin
Copy link
Member

JounQin commented Dec 10, 2023

OK, I'll take a look when I'm free.

@karlhorky
Copy link
Contributor Author

karlhorky commented Dec 17, 2023

I can confirm sql-formatter@15.0.2 is present in prettier-plugin-sql@0.18.0, and the dataTypeCase and functionCase options are working 🎉 Thanks for the release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

prettier-plugin-sql: Upgrade to sql-formatter@15
2 participants