Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set ecmaVersion: 2018 when parsing #4

Merged
merged 2 commits into from
Oct 23, 2017
Merged

Set ecmaVersion: 2018 when parsing #4

merged 2 commits into from
Oct 23, 2017

Conversation

goto-bus-stop
Copy link
Contributor

This allows parsing async functions and other new JavaScript
features.

Thanks!

@goto-bus-stop
Set ecmaVersion: 9 when parsing
face1da 
This allows parsing `async function`s and maybe other new JavaScript
features.
@twada
Copy link
Member

twada commented Oct 23, 2017

@goto-bus-stop Thank you for your contribution!
I prefer annual format like 2016,2017 for ecmaVersion (2018 in this case).
Once changed I'm 👍 to merge this.

@goto-bus-stop
Copy link
Contributor Author

aight, done!

@twada
Copy link
Member

twada commented Oct 23, 2017

@goto-bus-stop LGTM. Thanks!

@twada twada merged commit d59edbc into unassert-js:master Oct 23, 2017
@twada twada changed the title Set ecmaVersion: 9 when parsing Set ecmaVersion: 2018 when parsing Oct 23, 2017
@twada
Copy link
Member

twada commented Oct 23, 2017

Released as v2.1.0. Thank you @goto-bus-stop!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goto-bus-stop @twada