Skip parsing if file doesn't contain assertions #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unassertify is quite an expensive transform, because it does full parsing and code generation. That only needs to be done for files that contain assertions, though. This patch adds a quick check: if the string `assert` does not even occur in the file, we'll just skip it, saving some time.
|
@goto-bus-stop Thank you for your contribution! |
|
v2.1.1 has been released. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unassertify is quite an expensive transform, because it does full
parsing and code generation. That only needs to be done for files that
contain assertions, though. This patch adds a quick check: if the string
assertdoes not even occur in the file, we'll just skip it, savingsome time.