Wait for other worker thread on shutdown #2484
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When worker stop due to max-lifetime, the first thread will now wait for additional thread to complet before terminating the worker process.
This fix the issue described in #1894. With this change I never get any request error nor request that don't finish.
I think this will also fix the issue seen on production described in #2480
If you want that I make this wait behind an option, just ask and I'll update this PR.