plugins/python: use PyOS_*Fork stable API functions on 3.7+ #2655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid calling functions made private from 3.13+. And probably fixing issues with C extensions.
As it should have been since years :_)
xrmx
force-pushed
the
drop-pyimport-private-for-modern-python
branch
7 times, most recently
from
c1a3093
to
8d12fa1
Compare
Use current_frame instead
That is still in beta but removed private C APIs we were using.
xrmx
force-pushed
the
drop-pyimport-private-for-modern-python
branch
from
8d12fa1
to
d6211dc
Compare
|
I've build some packages for the upcoming Fedora 41 with this (which will ship 3.13 and currently has RC versions), and I can confirm that the code builds, and it so far hasn't blown up with the test cases that I have. As for the patch itself, may I suggest not nesting the |
|
@Lalufu thanks for checking, I'll merge this as is and then we can revise it later. |
Lalufu
added a commit
to Lalufu/uwsgi
that referenced
this pull request
Sep 8, 2024
As mentioned in unbit#2655, this changes the way support for python 3.13 is handled. Instead of handling python 3.13 as a minor change from 3.12, and handling support for it under the 3.12 `#ifdef` blocks, this breaks out 3.13 into its own block, apart from 3.12. This makes the code a bit more verbose, but makes it easier to see what the structures look like for different python versions.
xrmx
pushed a commit
to xrmx/uwsgi
that referenced
this pull request
Sep 15, 2024
As mentioned in unbit#2655, this changes the way support for python 3.13 is handled. Instead of handling python 3.13 as a minor change from 3.12, and handling support for it under the 3.12 `#ifdef` blocks, this breaks out 3.13 into its own block, apart from 3.12. This makes the code a bit more verbose, but makes it easier to see what the structures look like for different python versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid calling functions made private from 3.13+. And probably fixing issues with C extensions.