port pypy plugin to python3 #2662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
xrmx
reviewed
Sep 8, 2024
Comment on lines
+344
to
+347
| from paste.script.util.logging_config import fileConfig | ||
| fileConfig(c) | ||
| except ImportError: | ||
| print("PyPy WARNING: unable to load logging.config") | ||
| print("PyPy WARNING: unable to load paste.script.util.logging_config") |
There was a problem hiding this comment.
Is this some old patch that has been forwarded? This have been changed in 71464fb
There was a problem hiding this comment.
Yes this is, will review this better and submit fixes in the coming days.
xrmx
reviewed
Sep 8, 2024
| c = c[7:] | ||
| if c[0] != '/': | ||
| c = os.getcwd() + '/' + c | ||
| if c[0] != b'/'[0]: |
There was a problem hiding this comment.
It seems useless, you're right.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.