Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for java.io.File not being 'serializable' due to internal gradle cast #58

Closed

Conversation

alex-lmco
Copy link
Contributor

Fixes #57

Only 1 test fails when I run locally but it does anyways when I run it locally without my changes:

$ ./gradlew test

> Task :test
HelmCommandsPluginTest > should not create any tasks automatically FAILED
    org.gradle.api.internal.plugins.PluginApplicationException at HelmCommandsPluginTest.kt:59
        Caused by: org.gradle.api.internal.plugins.PluginApplicationException at HelmCommandsPluginTest.kt:59
            Caused by: org.gradle.api.reflect.ObjectInstantiationException at HelmCommandsPluginTest.kt:59
                Caused by: org.gradle.api.internal.tasks.DefaultTaskContainer$TaskCreationException at HelmCommandsPluginTest.kt:59
                    Caused by: org.opentest4j.AssertionFailedError at HelmCommandsPluginTest.kt:53

330 tests completed, 1 failed

@tkrullmann
Copy link
Member

Thanks for the work! But the issue seems to be that @InputFile must be used on RegularFileProperty task properties, instead of @Input.

Changing the annotation won't create any breaking changes, and RegularFileProperty is designed for working with file paths, so I'd rather keep it instead of changing it to a string.

@tkrullmann tkrullmann closed this Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Serialization Issue when using X.509 Client Certificates
2 participants