This repository has been archived by the owner on Apr 25, 2024. It is now read-only.
fix(wallet): basic coin selection on spend #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any way to disable the automatic scrolling (I think due to the error)? It's pretty annoying when attempting to select/deselect multiple UTXOs:
|
|
@humanumbrella do we want to disable the UTXO selection after the transaction has been authored (similar to how we disable everything else):
|
|
Yes, that makes sense. Looking. |
waldenraines
approved these changes
Jun 1, 2021
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow UTXO selection on spend. Works in both Redeem Script
and Wallet interfaces but the Wallet interface is not 100% feature complete. E.g. if you try to spend a single utxo from multiple addresses that will not work properly right now. However, within a multi-address setup, you should be able to do coin selection.Does this PR introduce a breaking change?
Does this PR fix an open issue?
Partially addresses #54