Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UNDERTOW-1837] ServletRequest#getLocalPort(), getLocalAddr() and get… #1044

Merged
merged 1 commit into from
Mar 30, 2021
Merged

[UNDERTOW-1837] ServletRequest#getLocalPort(), getLocalAddr() and get… #1044

merged 1 commit into from
Mar 30, 2021

Conversation

moulalis
Copy link
Contributor

@moulalis moulalis commented Mar 1, 2021 •
edited
Loading

This was referenced Mar 1, 2021
Merged
Merged
@moulalis moulalis force-pushed the master_UNDERTOW-1837 branch from ce4ad8a to c73e41d Compare March 1, 2021 08:24
@fl4via fl4via added bug fix Contains bug fix(es) failed CI Introduced new regession(s) during CI check waiting PR update Awaiting PR update(s) from contributor before merging labels Mar 4, 2021
@fl4via
Copy link
Member

fl4via commented Mar 4, 2021

@moulalis can you please check the following failures?
https://github.com/undertow-io/undertow/pull/1044/checks?check_run_id=2002486404
https://github.com/undertow-io/undertow/pull/1044/checks?check_run_id=2002486429
https://github.com/undertow-io/undertow/pull/1044/checks?check_run_id=2002486571
https://github.com/undertow-io/undertow/pull/1044/checks?check_run_id=2002486607
https://github.com/undertow-io/undertow/pull/1044/checks?check_run_id=2002485978
https://github.com/undertow-io/undertow/pull/1044/checks?check_run_id=2002486020
Even though the CI is not stable and we do have to cope with some test failures in the PRs (a problem we are working to solve), those failures are new and likely introduced by your PR.
To do a full run in your local machine, you need to run:
mvn clean package -Pproxy -Dmaven.test.failure.ignore=true -DfailIfNoTests=false -fae > output.txt
It looks to me, though, that simply running mvn test ProxyForwardedTestCase in servlet module will cause the failure.

@moulalis moulalis force-pushed the master_UNDERTOW-1837 branch 2 times, most recently from 4fbd44a to d4b901c Compare March 24, 2021 13:06
@moulalis
Copy link
Contributor Author

@moulalis can you please check the following failures?
https://github.com/undertow-io/undertow/pull/1044/checks?check_run_id=2002486404
https://github.com/undertow-io/undertow/pull/1044/checks?check_run_id=2002486429
https://github.com/undertow-io/undertow/pull/1044/checks?check_run_id=2002486571
https://github.com/undertow-io/undertow/pull/1044/checks?check_run_id=2002486607
https://github.com/undertow-io/undertow/pull/1044/checks?check_run_id=2002485978
https://github.com/undertow-io/undertow/pull/1044/checks?check_run_id=2002486020
Even though the CI is not stable and we do have to cope with some test failures in the PRs (a problem we are working to solve), those failures are new and likely introduced by your PR.
To do a full run in your local machine, you need to run:
mvn clean package -Pproxy -Dmaven.test.failure.ignore=true -DfailIfNoTests=false -fae > output.txt
It looks to me, though, that simply running mvn test ProxyForwardedTestCase in servlet module will cause the failure.

@fl4via could you please check it now, the failures are fixed.

@fl4via
Copy link
Member

fl4via commented Mar 30, 2021 •
edited
Loading

@moulalis we are still seeing some failures: https://github.com/undertow-io/undertow/pull/1044/checks?check_run_id=2184399947#step:10:559 all of them in Windows

[UNDERTOW-1837] ServletRequest#getLocalPort(), getLocalAddr() and get…
0a80b5b 
…LocalName() can return wrong information when ProxyPeerAddressHandler or ForwardedHandler is enabled
@moulalis moulalis force-pushed the master_UNDERTOW-1837 branch from d4b901c to 0a80b5b Compare March 30, 2021 06:24
@moulalis
Copy link
Contributor Author

@moulalis we are still seeing some failures: https://github.com/undertow-io/undertow/pull/1044/checks?check_run_id=2184399947#step:10:559 all of them in Windows

Hi @fl4via, please check it now, it's fixed. Thanks

@fl4via
Copy link
Member

fl4via commented Mar 30, 2021

@moulalis thanks!

@fl4via fl4via added next release This PR will be merged before next release or has already been merged (for payload double check) and removed failed CI Introduced new regession(s) during CI check waiting PR update Awaiting PR update(s) from contributor before merging labels Mar 30, 2021
@fl4via fl4via merged commit 53bc0c0 into undertow-io:master Mar 30, 2021
@fl4via fl4via removed the next release This PR will be merged before next release or has already been merged (for payload double check) label May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fl4via fl4via fl4via approved these changes

Assignees
No one assigned
Labels
bug fix Contains bug fix(es)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@moulalis @fl4via