Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new checks #14

Merged
merged 7 commits into from
Jun 19, 2023
Merged

Add new checks #14

merged 7 commits into from
Jun 19, 2023

Conversation

matheusfm
Copy link
Contributor

@matheusfm matheusfm commented Jun 19, 2023 •
edited
Loading

Description

Add new checks:

  • M-400: image tagged latest
  • M-401: unmanaged pod
  • M-402: readiness and startup probe not configured (do not check Job and CronJob)
  • M-403: liveness probe not configured (do not check Job and CronJob)
  • M-404: memory requests not specified
  • M-405: CPU requests not specified
  • M-406: memory not limited
  • M-407: CPU not limited

How has this been tested?

  • make test
  • kind create cluster && go run main.go scan

Checklist

  • I have labeled this PR with the relevant Type labels
  • I have documented my code (if applicable)
  • My changes are covered by tests

@matheusfm matheusfm added the enhancement New feature or request label Jun 19, 2023
@matheusfm matheusfm requested a review from monuelo June 19, 2023 14:10
@matheusfm matheusfm self-assigned this Jun 19, 2023
@matheusfm matheusfm merged commit 9161336 into main Jun 19, 2023
@matheusfm matheusfm deleted the feat/new-checks branch June 19, 2023 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monuelo monuelo monuelo approved these changes

Assignees

@matheusfm matheusfm

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matheusfm @monuelo