Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating to remove set-output #15

Merged
merged 1 commit into from
Oct 21, 2022
Merged

Updating to remove set-output #15

merged 1 commit into from
Oct 21, 2022

Conversation

nicleary
Copy link
Contributor

Per Github set-output is now deprecated and should be removed.

@unfor19 unfor19 merged commit 8a86d81 into unfor19:master Oct 21, 2022
@unfor19
Copy link
Owner

unfor19 commented Oct 21, 2022

@nicleary sorry for the delay
Thanks

@maxlapides
Copy link

@unfor19 Thanks for merging this one! When do you think this update will be available on the GitHub Actions Marketplace? https://github.com/marketplace/actions/install-aws-cli-action

@unfor19
Copy link
Owner

unfor19 commented Nov 4, 2022

@unfor19 Thanks for merging this one! When do you think this update will be available on the GitHub Actions Marketplace? https://github.com/marketplace/actions/install-aws-cli-action

Hi @maxlapides thanks for the reminder, I was out for a long time :)
I will create a new release later on today

Replies/inputs like this ticket are so valuable, thank you everyone for assisting with keeping this action up to date

Update- was able to create a release with my mobile device, so v1.0.4 includes this fix. Surprisingly, it was easy :)
I'll update the test action so the README won't show the red badge of failing tests, it bugs me

@maxlapides
Copy link

Hey thanks @unfor19! Really appreciate it. Quick question, I am discovering that when I update my workflow to use unfor19/install-aws-cli-action@v1.0.4, the workflow runs with the latest version of this action. But, when I use unfor19/install-aws-cli-action@v1, the workflow runs with an older version of this action. Is there some way to update the v1 tag also? I'm not sure how releasing to GitHub Marketplace works exactly!

@unfor19
Copy link
Owner

unfor19 commented Nov 7, 2022

Thanks @maxlapides
You're right; setting v1 doesn't mean you're using the latest v1 (1.0.4), which is what I would expect.

Thanks for bringing it up, I'm reading about it, and I'll see if I can tweak the version to avoid modifying end-users workflows.

This seems to be like a good start - https://docs.github.com/en/actions/creating-actions/about-custom-actions#using-tags-for-release-management

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants