fix(types): update AndroidPermission and AndroidFeature

[sunpm]

Description 描述

添加缺少的类型

Linked Issues 关联的 Issues

Additional context 额外上下文

Summary by CodeRabbit

• New Features
  • Enhanced Android permissions handling by adding support for specifying optional features in the app configuration.

[coderabbitai]

Walkthrough

The recent update expands the AndroidPermission type, now allowing the inclusion of Android features directly within the type declarations. This enhancement offers more flexibility in managing app permissions and features in the configuration files.

Changes

File Path	Change Summary
.../config/types/appPlus.ts	Updated AndroidPermission type to include <uses-feature android:name="${AndroidPermissionName}"/>

🐰✨
In the code's green field, under the silicon sky,
A new line sprouts, where permissions lie.
Now with features grand, our apps expand,
A hop, a skip, in digital land.
🌟📱🐇

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 311abeb and 6b48927.

Files selected for processing (1)

• packages/core/src/config/types/appPlus.ts (1 hunks)

Additional comments not posted (1)

packages/core/src/config/types/appPlus.ts (1)

6-6: Addition of <uses-feature> to AndroidPermission type enhances flexibility.

This change allows for a broader definition of Android permissions and features, accommodating more complex app configurations. Ensure that all references to AndroidPermission are updated to handle this new option where necessary.

[ModyQyW]

我是从 https://developer.android.com/reference/android/Manifest.permission 复制的，但是里面没有 FLASHLIGHT，你方便告诉我更完整的列表在哪里吗？

我觉得 uses-feature 和 uses-permission 的 enum 最好是分开，否则可能会错误引导用户，可以麻烦你修改一下吗？

export type AndroidPermissionName = ''|''|...

export type AndroidPermission = `<uses-permission android:name="${AndroidPermissionName}" />` | `<uses-permission android:name="${AndroidPermissionName}"/>`

export type AndroidFeatureName = ''|''|...

export type AndroidFeature = `<uses-feature android:name="${AndroidFeatureName}" />` | `<uses-feature android:name="${AndroidFeatureName}"/>`

此外我还在犹豫要不要重命名 AndroidPermissionName -> AndroidUsesPermissionName、 AndroidPermission -> AndroidUsesPermission、AndroidFeatureName -> AndroidUsesFeatureName、AndroidFeature -> AndroidUeseFeature，你有什么想法吗？

[sunpm]

我没开发过安卓，也不太清楚这些配置是不是有效的，只是使用 cli 创建项目时它已存在，下面是官方 cli 创建的模版仓库

https://github.com/dcloudio/uni-preset-vue/blob/ff5c6225b8726571e88ffb71ba64326ee4ffa38c/src/manifest.json#L26-L40

稍等会重新提交一个 commit，将 enum 分开维护

此外我还在犹豫要不要重命名

我觉得应该问题不大，现在也没有冲突，不太清楚添加 Uses 标识的考量是什么

[coderabbitai]

Actionable comments posted: 3

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 6b48927 and 063ce8a.

Files selected for processing (1)

• packages/core/src/config/types/appPlus.ts (2 hunks)

Additional comments not posted (1)

packages/core/src/config/types/appPlus.ts (1)

294-299: Ensure correct usage of permission and feature types.

[coderabbitai]

The addition of FLASHLIGHT permission is missing.

Please add 'android.permission.FLASHLIGHT' to the AndroidPermissionName type as suggested in the PR comments to ensure completeness.

[coderabbitai]

Separate enums for uses-feature and uses-permission.

To avoid confusion as suggested in the PR comments, consider separating the enums for uses-feature and uses-permission. This will make the type definitions clearer and prevent misuse.

[coderabbitai]

Consider renaming for clarity.

As suggested in the PR comments, consider renaming AndroidPermissionName to AndroidUsesPermissionName and AndroidFeatureName to AndroidUsesFeatureName to clarify their usage in the context of uses-permission and uses-feature respectively.

[ModyQyW]

非常感谢！我这边看看还有什么需要补充，可能今晚或者明天发一版！♥️