CLDR-17115 Update languages/codes; run ConvertLanguageData #3509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Update world_bank_data.csv by downloading -URL is https://databank.worldbank.org/reports.aspx?source=world-development-indicators -Note: running AddPopulationData caused no changes -Update supplementalData.xml by running ConvertLanguageData -This caused removal of tok (Tok Pona) and vo (Volapük), and revision of comment for ace (Achinese to Acehnese)
|
ConvertLanguageData reported errors, which I have not been able to fix: |
|
Maybe names such as "Africa Eastern and Southern" and "Central Europe and the Baltics" are for groups that don't require codes as far as CLDR is concerned? In which case those error messages would not be problematic. It's not clear how to address errors like "language population > country population", "missing language/population data for CLDR locale", or warnings like "Missing Data"... |
macchiati
approved these changes
Feb 21, 2024
There was a problem hiding this comment.
I review the console listing and XML changes. The XML changes look good.
Of the console changes, the errors are not serious, but are errors. The warnings are mostly, unnecessary (and the Factbook items look like debug printouts. Please file a separate bug to clean up the tool, with that listing.
|
On Wed, Feb 21, 2024 at 8:54 AM Tom Bishop ***@***.***> wrote:
Maybe names such as "Africa Eastern and Southern" and "Central Europe and
the Baltics" are for groups that don't require codes as far as CLDR is
concerned? In which case those error messages would not be problematic.
Yes, that's what I think also.
It's not clear how to address errors like "language population > country
population", "missing language/population data for CLDR locale", or
warnings like "Missing Data"...
Those are not serious enough to block us now.
… —
Reply to this email directly, view it on GitHub
<#3509 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACJLEMAVVYUX5Z7YNAQVS2DYUYRC3AVCNFSM6AAAAABDTL4GMOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJXGI4DQMZWHE>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Update world_bank_data.csv by downloading
-URL is https://databank.worldbank.org/reports.aspx?source=world-development-indicators
-Note: running AddPopulationData caused no changes
-Update supplementalData.xml by running ConvertLanguageData
-This caused removal of tok (Tok Pona) and vo (Volapük), and revision of comment for ace (Achinese to Acehnese)
CLDR-17115
ALLOW_MANY_COMMITS=true