Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLDR-17388 v45 update logKnownIssues #3514

Merged
merged 4 commits into from
Feb 24, 2024
Merged

CLDR-17388 v45 update logKnownIssues #3514

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
aba2d4d
CLDR-17388 update known issues
srl295 Feb 23, 2024
496ffcf
CLDR-17388 update known issues
srl295 Feb 23, 2024
433705c
CLDR-17388 update known issues
srl295 Feb 23, 2024
e64453c
CLDR-17388 update known issues
srl295 Feb 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tools/cldr-code/src/test/java/org/unicode/cldr/unittest/LanguageInfoTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ public void TestChinese() {
static final ULocale MUL = new ULocale(LocaleNames.MUL);

public void testFallbacks() {
if (logKnownIssue("ICU-21241", "waiting on LocaleMatcherData update")) {
if (logKnownIssue("CLDR-17189", "waiting on LocaleMatcherData update")) {
return;
}
for (R4<String, String, Integer, Boolean> foo :
Expand Down
10 changes: 0 additions & 10 deletions tools/cldr-code/src/test/java/org/unicode/cldr/unittest/LikelySubtagsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,16 +223,6 @@
}

public void TestCompleteness() {
// if (logKnownIssue("Cldrbug:7121",
// "Problems with likely subtags test")) {
// return;
// }
// checkAdding("und_Bopo");
// checkAdding("und_Brai");
// checkAdding("und_Limb");
// checkAdding("und_Cakm");
// checkAdding("und_Shaw");

final LanguageTagParser ltp = new LanguageTagParser();
if (DEBUG) {
System.out.println(TAGS.languages.size() + "\t" + TAGS.languages);
Expand Down Expand Up @@ -546,7 +536,7 @@
}

if (!collectedBad.isEmpty()) {
warnln(

Check warning on line 539 in tools/cldr-code/src/test/java/org/unicode/cldr/unittest/LikelySubtagsTest.java

View workflow job for this annotation

GitHub Actions / build 

 (LikelySubtagsTest.java:539)  Warning: Locales have 224 unexpected characters in main and/or aux:	[҂״܀-܍०-९৲-৺੦-੯૰౦-౯೦-೯໐-໙၀-၉၏႐-႙႞႟፠-፼᎐-᎙᠐-᠙꒐-꓆𞅏{a\:}{ch’}{e\:}{i\:}{k’}{o\:}{ts’}{tł’}{t’}{à\:}{á\:}{è\:}{é\:}{ì\:}{í\:}{ò\:}{ó\:}{ଅ\:}{ଆ\:}{ଏ\:}]
"Locales have "
+ collectedBad.size()
+ " unexpected characters in main and/or aux:\t"
Expand Down Expand Up @@ -791,7 +781,7 @@
// SUPPLEMENTAL_DATA_INFO.getLikelyOrigins().get(value);
// fieldToOrigin.put(value, origin == null ? "n/a" : origin);
// }
warnln("Bad status=" + entry.getKey() + " for " + entry.getValue());

Check warning on line 784 in tools/cldr-code/src/test/java/org/unicode/cldr/unittest/LikelySubtagsTest.java

View workflow job for this annotation

GitHub Actions / build 

 (LikelySubtagsTest.java:784)  Warning: Bad status=macroregion for [001, 419]
}
}
}
Expand Down
12 changes: 2 additions & 10 deletions tools/cldr-code/src/test/java/org/unicode/cldr/unittest/TestAttributeValues.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,12 +199,8 @@
}
// XMLFileReader.read("noId", inputStreamReader, -1, true, myHandler);
} catch (XMLStreamException e) {
if (!logKnownIssue("cldrbug 10120", "XML reading issue")) {
warnln("Can't read " + fullFile);
} else {
throw (IllegalArgumentException)
new IllegalArgumentException("Can't read " + fullFile).initCause(e);
}
throw (IllegalArgumentException)
new IllegalArgumentException("Can't read " + fullFile).initCause(e);
} catch (Throwable e) {
if (r == null) throw e;
throw new IllegalArgumentException(" at " + r.getLocation(), e);
Expand Down Expand Up @@ -309,13 +305,9 @@
void show(boolean verbose, ImmutableSet<ValueStatus> retain) {
if (dtdData.dtdType == DtdType.keyboard3
&& testLog.logKnownIssue("CLDR-14974", "skipping for keyboard")) {
testLog.warnln("Skipping for keyboard3");

Check warning on line 308 in tools/cldr-code/src/test/java/org/unicode/cldr/unittest/TestAttributeValues.java

View workflow job for this annotation

GitHub Actions / build 

 (TestAttributeValues.java:308)  Warning: Skipping for keyboard3
}
boolean haveProblems = false;
// if (testLog.logKnownIssue("cldrbug 10120", "Don't enable error until
// complete")) {
// testLog.warnln("Counts: " + counter.toString());
// } else
for (ValueStatus valueStatus : ValueStatus.values()) {
if (valueStatus == ValueStatus.valid) {
continue;
Expand Down
6 changes: 0 additions & 6 deletions tools/cldr-code/src/test/java/org/unicode/cldr/unittest/TestCLDRFile.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -795,12 +795,6 @@ public void TestFileIds() {
}
String likely = likelySubtags.minimize(loc);
if (!localesToDirs.containsKey(parent)) {
// if (ldmlDir == LdmlDir.rbnf && source == Source.common &&
// parent.equals("en_001") && loc.equals("en_IN") &&
// logKnownIssue("cldrbug:10456", "Missing parent
// (en_001) for en_IN in common/rbnf")) {
// continue;
// }
errln(
"Missing parent ("
+ parent
Expand Down
2 changes: 1 addition & 1 deletion tools/cldr-code/src/test/java/org/unicode/cldr/unittest/TestPaths.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -542,7 +542,7 @@ public void TestNonLdml() {
// counter, removed, nonFinalValues);
if (type != DtdType.keyboardTest3
|| !logKnownIssue(
"CLDR-15034",
"CLDR-17398",
"keyboardTest data appears as duplicate xpaths")) {
errln(
"Duplicate "
Expand Down
20 changes: 8 additions & 12 deletions tools/cldr-code/src/test/java/org/unicode/cldr/unittest/TestSupplementalInfo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -947,9 +947,7 @@ public void TestTimeData() {
+ oldSchool
+ " in allowed: "
+ preferredAndAllowedHour.allowed;
// if (!logKnownIssue("cldrbug:11448", message)) {
errln(message);
// }
}
break;
}
Expand Down Expand Up @@ -1587,9 +1585,14 @@ public void TestSupplementalCurrency() {
cldrCountries.add(x.getFirst());
}
if (!isoCountries.equals(cldrCountries)) {
if (!logKnownIssue(
"cldrbug:10765", "Missing codes compared to ISO: " + missing.toString())) {

// TODO 17397: remove isKnownIssue and the if around errln when the logknown issue
// goes away.
final boolean skipKnownIssue =
currency.equals("ANG")
&& isoCountries.isEmpty()
&& cldrCountries.equals(Set.of("CW", "SX"))
&& logKnownIssue("CLDR-17397", "Mismatched codes " + cldrCountries);
if (!skipKnownIssue) {
Comment on lines +1588 to +1595
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is now a very specific logKnownIssue. It won't mask future issues, even if we somehow don't work on CLDR-17397

errln(
"Mismatch between ISO and Cldr modern currencies for "
+ currency
Expand Down Expand Up @@ -1871,13 +1874,6 @@ public void TestPluralCompleteness() {
testLocales.contains(locale) ? CoverageIssue.error : CoverageIssue.log;
CoverageIssue needsCoverage2 =
needsCoverage == CoverageIssue.error ? CoverageIssue.warn : needsCoverage;

// if (logKnownIssue("Cldrbug:8809", "Missing plural rules/samples be and ga
// locales")) {
// if (locale.equals("be") || locale.equals("ga")) {
// needsCoverage = CoverageIssue.warn;
// }
// }
PluralRulesFactory prf =
PluralRulesFactory.getInstance(
CLDRConfig.getInstance().getSupplementalDataInfo());
Expand Down
7 changes: 0 additions & 7 deletions tools/cldr-code/src/test/java/org/unicode/cldr/unittest/TestTransforms.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -672,13 +672,6 @@ public void TestCasing() {

String lithuanianSource =
"I \u00CF J J\u0308 \u012E \u012E\u0308 \u00CC \u00CD \u0128 xi\u0307\u0308 xj\u0307\u0308 x\u012F\u0307\u0308 xi\u0307\u0300 xi\u0307\u0301 xi\u0307\u0303 XI X\u00CF XJ XJ\u0308 X\u012E X\u012E\u0308";
// The following test was formerly skipped with
// !logKnownIssue("11094", "Fix ICU4J UCharacter.toTitleCase/toLowerCase for lt").
// However [https://unicode-org.atlassian.net/browse/ICU-11094] is supposedly
// fixed in the version of ICU4J currently in CLDR, but removing the logKnownIssue
// to execute the test results in test failures, mainly for i\u0307\u0308.
// So I am changing the logKnownIssue to reference a CLDR ticket about
// investigating the test (it may be wrong).
if (!logKnownIssue(
"cldrbug:13313", "Investigate the Lithuanian casing test, it may be wrong")) {
Transliterator ltTitle =
Expand Down
4 changes: 0 additions & 4 deletions tools/cldr-code/src/test/java/org/unicode/cldr/unittest/TestValidity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,10 +192,6 @@ public void TestCompatibility() {
if (ALLOWED_MISSING.contains(code)) {
continue;
}
if (code.equals("cqzzzz")
&& logKnownIssue("CLDR-16464", "Skipping cqzzzz")) {
continue;
}
errln(
messages,
type
Expand Down
Loading