Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-17407 check for anomalies and fix #3522

Conversation

macchiati
Copy link
Member

CLDR-17407

Regenerated the coverage and charts while doing this.

common/properties/coverageLevels.txt

  • Toki Pona dropped from Basic

common/supplemental/coverageLevels.xml

  • modified because the previous method for skipping beaufort was not working

tools/cldr-code/src/main/java/org/unicode/cldr/util/StandardCodes.java

  • Made the CODE_FALLBACK not include deprecated timezones (eg Currie). Guts are in SupplementalDataInfo

tools/cldr-code/src/main/java/org/unicode/cldr/util/SupplementalDataInfo.java

  • While doing this, added some internal structure to make it easier to get BCP47 data. The old mechanism, searching for pairs is awkward to use.
  • Also added a backmapping from the aliases (eg long TZ names) to the subtype (eg the short TZ names)
  • goodTimezones takes the available codes, and subtracts those that are deprecated, by getting their shortIds, then looking up in the BCP47 info.

tools/cldr-code/src/main/resources/org/unicode/cldr/util/data/Locales.txt

  • Dropped Nigerian Pidgin and Maori targets to moderate for v45 (they were really bad). Will let TC know about this change, so that they can be bumped up again for v46 if they are really targets.

tools/cldr-code/src/test/java/org/unicode/cldr/util/TestStandardCodes.java

  • added quick test

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

@macchiati
Copy link
Member Author

Adding @AEApple & @srl295 because of the target change and Toki Pona drop

@macchiati macchiati self-assigned this Feb 26, 2024
@macchiati
Copy link
Member Author

Resetting to Draft until I figure out why the build isn't working.

@macchiati macchiati marked this pull request as draft February 26, 2024 08:34
@srl295
Copy link
Member

srl295 commented Feb 26, 2024

for pcm there was an issue with one of the vetters using a different orthography.

@macchiati macchiati marked this pull request as ready for review February 26, 2024 21:58
@macchiati
Copy link
Member Author

This still doesn't handle beaufort properly, but I'd like to merge this and then have a followup.

@macchiati macchiati merged commit a5825d3 into unicode-org:main Feb 27, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants