CLDR-17071 Do not create unused db table sf_loc2forum; improve localeToForum #4034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ToForum -Remove code that creates unused db table sf_loc2forum -Revise the implementation of localeToForum by calling getLanguage instead of toULocale().getLanguage
|
Note: after this is merged, we should remove the actual table sf_loc2forum from the production db:
|
srl295
approved these changes
Sep 10, 2024
haytenf
pushed a commit
to haytenf/cldr
that referenced
this pull request
Sep 17, 2024
conradarcturus
pushed a commit
that referenced
this pull request
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Remove code that creates unused db table sf_loc2forum
-Revise the implementation of localeToForum by calling getLanguage instead of toULocale().getLanguage
CLDR-17071
ALLOW_MANY_COMMITS=true