Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-22220 BRS73RC Update version number and regenerate configure v73.1 #2375

Merged
merged 1 commit into from
Mar 17, 2023

Conversation

rp9-next
Copy link
Contributor

@rp9-next rp9-next commented Mar 16, 2023

Checklist
  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22220
  • Required: The PR title must be prefixed with a JIRA Issue number.
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number.
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

icu4j/build.properties Outdated Show resolved Hide resolved
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

Copy link
Contributor

@pedberg-icu pedberg-icu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm tnx

@rp9-next did you check if the .jar files actually have meaningful changes (other than differences in zip compression)?

@rp9-next
Copy link
Contributor Author

The last time we checked, while two of the JAR files were exactly same (apart from the "Created By" changes in the MANIFEST.MF)
I believe there were changes with respect to the version number encoded in "*.cnv" and some other changes in ".res" files in testdata.jar

@rp9-next rp9-next merged commit 7a67099 into unicode-org:main Mar 17, 2023
@rp9-next rp9-next deleted the brs-rc-update-version-73.1 branch March 17, 2023 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants