Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICU-22354 Update actions and platforms in GitHub Actions workflows #2428

Merged
merged 1 commit into from
Jun 27, 2023
Merged

ICU-22354 Update actions and platforms in GitHub Actions workflows #2428

merged 1 commit into from
Jun 27, 2023

Conversation

VoltrexKeyva
Copy link
Contributor

@VoltrexKeyva VoltrexKeyva commented Apr 14, 2023 •
edited
Loading

Checklist
  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22354
  • Required: The PR title must be prefixed with a JIRA Issue number.
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number.
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • icu4c/source/runConfigureICU is now changed in the branch

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@FrankYFTang
Copy link
Contributor

The ticket is not yet accepted. Once ICU-TC accept that and @markusicu is ok with this. I will approve and merge.

@markusicu markusicu self-requested a review April 20, 2023 16:20
FrankYFTang
FrankYFTang reviewed Apr 20, 2023
View reviewed changes
icu4c/source/runConfigureICU Outdated
@@ -256,16 +256,16 @@ case $platform in
CXX=g++; export CXX
RELEASE_CFLAGS='-O3'
RELEASE_CXXFLAGS='-O3'
DEBUG_CFLAGS='-g'
DEBUG_CXXFLAGS='-g'
DEBUG_CFLAGS='-g -gdwarf-4'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have concern about this. Should we leave this flag out of runConfigureICU but instead passing in from the command line or yml file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can try passing it from the command line to see if it works that way.

@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • .github/workflows/icu_valgrind.yml is different
  • icu4c/source/runConfigureICU is no longer changed in the branch

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@VoltrexKeyva
Copy link
Contributor Author

The failing test seems to be unrelated to my changes, @FrankYFTang can you try rerunning it?

@FrankYFTang
Copy link
Contributor

The failing test seems to be unrelated to my changes, @FrankYFTang can you try rerunning it?

yes, I am aware of that. That is killed by timeout 40 mins. and I solve it by #2436
but you need to rebase that that I think before I rerun

@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • .github/workflows/icu_ci.yml is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@VoltrexKeyva
Copy link
Contributor Author

@FrankYFTang can you check and run the CI? Apologies for the ping.

@FrankYFTang
Copy link
Contributor

somehow gcc-debug-build-and-test failed. Re-run the test.

FrankYFTang
FrankYFTang previously approved these changes Apr 28, 2023
View reviewed changes
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • .github/workflows/icu_valgrind.yml is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@VoltrexKeyva
Copy link
Contributor Author

@FrankYFTang can you run the tests again?

@VoltrexKeyva
Copy link
Contributor Author

VoltrexKeyva commented May 18, 2023 •
edited
Loading

Can this be reviewed or should I rebase again?

@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • .github/workflows/cache_retain.yml is different
  • .github/workflows/icu_ci.yml is different
  • .github/workflows/icu_envtest.yml is different
  • .github/workflows/icu_merge_ci.yml is different
  • .github/workflows/icu_valgrind.yml is different
  • .github/workflows/jekyll-gh-pages.yml is different
  • .github/workflows/maven.yaml is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

FrankYFTang
FrankYFTang approved these changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@FrankYFTang FrankYFTang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FrankYFTang FrankYFTang merged commit b575f7c into unicode-org:main Jun 27, 2023
70 checks passed
@VoltrexKeyva VoltrexKeyva deleted the update-actions branch June 27, 2023 19:08
FrankYFTang added a commit to FrankYFTang/icu that referenced this pull request Jun 27, 2023
@FrankYFTang
ICU-22354 Revert benchmark-action changes
3470aa2 
Revert the change of benchmark-action in
unicode-org#2428 which cause
post merge test brekage.

See https://github.com/unicode-org/icu/actions/runs/5393383252/jobs/9793048045
for the problem
@FrankYFTang FrankYFTang mentioned this pull request Jun 27, 2023
Merged
7 tasks
FrankYFTang added a commit that referenced this pull request Jun 27, 2023
@FrankYFTang
ICU-22354 Revert benchmark-action changes
f1b13a8 
Revert the change of benchmark-action in
#2428 which cause
post merge test brekage.

See https://github.com/unicode-org/icu/actions/runs/5393383252/jobs/9793048045
for the problem
FrankYFTang added a commit to FrankYFTang/icu that referenced this pull request Jul 10, 2023
@FrankYFTang
ICU-22354 Revert benchmark-action changes
729eeb0 
Revert the change of benchmark-action in
unicode-org#2428 which cause
post merge test brekage.

See https://github.com/unicode-org/icu/actions/runs/5393383252/jobs/9793048045
for the problem
catamorphism pushed a commit to catamorphism/icu that referenced this pull request Nov 1, 2023
@FrankYFTang @catamorphism
ICU-22354 Revert benchmark-action changes
7fa9d17 
Revert the change of benchmark-action in
unicode-org#2428 which cause
post merge test brekage.

See https://github.com/unicode-org/icu/actions/runs/5393383252/jobs/9793048045
for the problem
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrankYFTang FrankYFTang FrankYFTang approved these changes

@markusicu markusicu Awaiting requested review from markusicu

Assignees

@FrankYFTang FrankYFTang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VoltrexKeyva @FrankYFTang