Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-22421 Remove two unused internal methods in gregorian cal #2511

Merged
merged 1 commit into from
Jun 22, 2023

Conversation

FrankYFTang
Copy link
Contributor

Remove pinDayOfMonth() and yearLength(int32_t year) from GregorianCalendar.

These two methods are

  1. Unused by any code inside ICU, not in source/{common,i18n,test}.
  2. Marked as @internal in the header.
  3. Wrap inside #ifndef U_HIDE_INTERNAL_API block in the header
  4. In "protected:" section.
  5. No ICU4J counterpart.

The yearLength(int32_t year) dup the functionality as handleGetYearLength of the same class and that one is the correct one to be keep and used..
There is another yearLength() w/o the year as parameter should NOT be removed and still needed internally.

Checklist
  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22421
  • Required: The PR title must be prefixed with a JIRA Issue number.
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number.
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

Remove pinDayOfMonth() and yearLength(int32_t year)
from GregorianCalendar.

These two methods are
1. Unused by any code inside ICU, not in source/{common,i18n,test}.
2. Marked as @internal in the header.
3. Wrap inside #ifndef U_HIDE_INTERNAL_API block in the header
4. In "protected:" section.
5. No ICU4J counterpart.

The yearLength(int32_t year) dup the functionality as
handleGetYearLength of the same class and that one is the correct one to
be keep and used..
There is another yearLength() w/o the year as parameter should NOT be
removed and still needed internally.
@FrankYFTang FrankYFTang requested review from sffc and mihnita June 22, 2023 17:46
Copy link
Contributor

@mihnita mihnita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks
M.

@FrankYFTang FrankYFTang merged commit 26bd70e into unicode-org:main Jun 22, 2023
101 checks passed
@sffc sffc removed their request for review June 23, 2023 00:33
@FrankYFTang FrankYFTang deleted the pinDayOfMonth branch June 23, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants