ICU-13836 C++ port of Java impl of plural support for compact decimal notation #972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See previous ICU4J implementation in PR #938 |
sffc
requested changes
Feb 1, 2020
| cas.expectedString, | ||
| actualString); | ||
| assertDoubleEquals( | ||
| u"compact decimal %d, n operand vs. expected" + Int64ToUnicodeString(cas.input), |
There was a problem hiding this comment.
Done. Split up the test msg string and used string concatenation.
There was a problem hiding this comment.
If it's a double you can use DoubleToUnicodeString instead of Int64ToUnicodeString
sffc
reviewed
Feb 1, 2020
icu4j/main/classes/core/src/com/ibm/icu/impl/number/DecimalQuantity_AbstractBCD.java
Outdated
Show resolved
Hide resolved
icu4j/main/tests/core/src/com/ibm/icu/dev/impl/number/DecimalQuantity_SimpleStorage.java
Outdated
Show resolved
Hide resolved
sffc
previously approved these changes
Feb 1, 2020
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
|
All the CI checks passed, so I squashed and force-pushed. @sffc can you stamp the PR with another approval due to the branch squash? |
sffc
approved these changes
Feb 4, 2020
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist