Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement generalized decimal pattern parsing #567

Open
sffc opened this issue Mar 23, 2021 · 4 comments
Open

Implement generalized decimal pattern parsing #567

sffc opened this issue Mar 23, 2021 · 4 comments
Labels
C-numbers Component: Numbers, units, currencies good first issue Good for newcomers help wanted Issue needs an assignee S-small Size: One afternoon (small bug fix or enhancement) T-core Type: Required functionality
Milestone
Priority Backlog ...

Comments

@sffc
Copy link
Member

sffc commented Mar 23, 2021

In #541, I use a temporary decimal pattern parsing algorithm as a placeholder for the main one that we will need to write in order to handle the full spectrum of CLDR data.

This algorithm will need to:

I think we should consider following a model similar to that in DateTimeFormat, where we have a public Pattern type, which is serializable and allowed to live in the data struct, with a human-readable representation for JSON and a machine-readable representation for Bincode (and rkyv).
@sffc sffc added T-core Type: Required functionality C-numbers Component: Numbers, units, currencies labels Mar 23, 2021
@gregtatum
Copy link
Member

I think we should consider following a model similar to that in DateTimeFormat, where we have a public Pattern type, which is serializable and allowed to live in the data struct, with a human-readable representation for JSON and a machine-readable representation for Bincode (and rkyv).

👍

@sffc sffc added this to the ICU4X 0.4 milestone Apr 19, 2021
@sffc sffc added the S-small Size: One afternoon (small bug fix or enhancement) label Apr 19, 2021
@sffc sffc self-assigned this Apr 19, 2021
@sffc
Copy link
Member Author

sffc commented Apr 19, 2021

Dependency of #275

@sffc sffc removed their assignment Aug 11, 2021
@sffc sffc added good first issue Good for newcomers help wanted Issue needs an assignee labels Aug 11, 2021
@sffc sffc modified the milestones: ICU4X 0.4, ICU4X 0.5 Aug 11, 2021
@sffc sffc self-assigned this Aug 31, 2021
@sffc sffc removed the help wanted Issue needs an assignee label Aug 31, 2021
@sffc
Copy link
Member Author

sffc commented Aug 31, 2021

@younies is going to take a look at this.

@sffc sffc assigned sapriyag and unassigned sffc Oct 19, 2021
@sffc
Copy link
Member Author

sffc commented Jan 27, 2022

Needed for currency. Assigning to @robertbastian

@sffc sffc assigned robertbastian and unassigned sapriyag Jan 27, 2022
@sffc sffc modified the milestones: ICU4X 0.5, ICU4X 0.6 Jan 27, 2022
@robertbastian robertbastian modified the milestones: ICU4X 0.6, ICU4X 1.1 Apr 1, 2022
@sffc sffc added the help wanted Issue needs an assignee label May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-numbers Component: Numbers, units, currencies good first issue Good for newcomers help wanted Issue needs an assignee S-small Size: One afternoon (small bug fix or enhancement) T-core Type: Required functionality
Projects
None yet
Milestone
Priority Backlog ⟨P3⟩
Development

No branches or pull requests
4 participants
@sffc @gregtatum @robertbastian @sapriyag