-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLDR-13221 format for currency symbol at decimal point #1137
Conversation
docs/ldml/tr35-numbers.md
Outdated
|
||
Before | After | Decimal | ||
-------|-------|------- | ||
¤#,##0.00|#,##0.00¤|#,##0¤00 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can the pattern #,##0¤00
ever actually occur in CLDR data? If it can, then we'll need to change the EBNF for number patterns (assuming there is one).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought we had an EBNF for these, but I can't find one. These number patterns continue becoming more and more complex to parse. I'm going to need to implement a parser in ICU4X. Before I do that, I would really like to have a formal grammar that I can implement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/[0#]¤[0#]/ does not occur in any CLDR data (current or past), so I don't think there is any real compatibility concern.
I think an EBNF is an excellent idea. Please file a ticket for that and we can work on it (for next release).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more questions
docs/ldml/tr35-numbers.md
Outdated
|
||
Before | After | Decimal | ||
-------|-------|------- | ||
¤#,##0.00|#,##0.00¤|#,##0¤00 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought we had an EBNF for these, but I can't find one. These number patterns continue becoming more and more complex to parse. I'm going to need to implement a parser in ICU4X. Before I do that, I would really like to have a formal grammar that I can implement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! This is much better.
I see now what you were trying to do in the table. I think the new table layout is clearer, even though it loses the vertical alignment of the "before" and "after" patterns.
0f6a37d
to
9a86dc4
Compare
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
Need another review because of squash to fix commit message (sigh) |
Checklist