Extend DateTimeFormat to support other calendars #1339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
requested review from
gregtatum,
nordzilla,
zbraniecki and
a team
as code owners
This was referenced Nov 23, 2021
Manishearth
changed the title
zbraniecki
approved these changes
Nov 24, 2021
| s | ||
| #[inline] | ||
| pub fn format_to_string(&self, value: &impl DateTimeInput<Calendar = C>) -> String { | ||
| self.0.format_to_string(value) | ||
| } |
There was a problem hiding this comment.
question: can you Deref to self.0?
There was a problem hiding this comment.
Yes, but that would make self.0 a public part of the API.
Plus it's typically not considered good style to use Deref for coercions when pointers aren't involved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1316, fixes #1115
This implements the low level API discussed in #1316: There is a public
DateTimeFormat<C>API withCas a calendar type, and it is internally backed by a "raw"DateTimeFormattype with the actual implementation (same goes for ZonedDateTimeFormat). Users must specify a calendar on construction and only dates which match the calendar type can be passed in. The raw API does no such checking and is meant to be a building block for the eventual higher level API discussed in #1316.Todo (I plan to finish these items today, just wanted to have a PR up before lunch)
Unfortunately it is not yet worth it to properly test this since the Buddhist calendar has identical symbols to the Gregorian one, aside from era formatting which is not yet supported (#1312, I might work on this next).
I did verify that this PR works and loads data from the correct spot by modifying some month names in the CLDR data, regenerating testdata, and running the
work_logexample: