Include era symbol information in data #1344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
requested review from
gregtatum,
nordzilla,
sffc,
zbraniecki and
a team
as code owners
|
This does not handle era variants; that's something that can be decided later. |
sffc
previously approved these changes
Nov 24, 2021
Manishearth
force-pushed
the
era-data
branch
from
1642a07 to
6f5abcb
Compare
|
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
sffc
approved these changes
Nov 24, 2021
nordzilla
approved these changes
Nov 25, 2021
| number: year.0, | ||
| related_iso: year.0, | ||
| } | ||
| } else { | ||
| types::Year { | ||
| era: types::Era(tinystr8!("bce")), | ||
| era: types::Era(tinystr8!("bc")), |
There was a problem hiding this comment.
question
Why are we not using TinyStr4 for these?
There was a problem hiding this comment.
Japanese era codes are bigger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First step of #1312
This hardcodes an era map; this is basically the only option we have if we're going to use an era code scheme.