Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Constrain zcf impl for [T] on T: 'static #1392

Merged
merged 1 commit into from
Dec 14, 2021
Merged

Constrain zcf impl for [T] on T: 'static #1392

merged 1 commit into from
Dec 14, 2021

Conversation

Manishearth
Copy link
Member

@Manishearth Manishearth commented Dec 14, 2021 •
edited
Loading

This used to work, but it was a bug in rustc that it did, because our Yokeable impl on &T requires T: 'static.

Regression filed at rust-lang/rust#91899

@dminor
Copy link
Contributor

dminor commented Dec 14, 2021

Thanks for fixing this!

@dminor dminor merged commit 6fac854 into unicode-org:main Dec 14, 2021
@Manishearth Manishearth deleted the yoke-fix branch December 14, 2021 16:37
@hellomsg hellomsg mentioned this pull request Jan 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sffc sffc sffc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Manishearth @dminor @sffc